| commit | a0c798e3f31b9e63b4b3bb405a6082794e4867a4 | [log] [tgz] |
|---|---|---|
| author | Marcin Czech <maczech@gmail.com> | Wed Feb 28 14:01:17 2024 +0100 |
| committer | Marcin Czech <maczech@gmail.com> | Wed Feb 28 14:03:58 2024 +0100 |
| tree | e9aec654708d124347a89e05816c90dc28e1bc2b | |
| parent | 08d22e856792b9cb90ac2908652c84a32066946e [diff] |
Use new BrokerApi method for disconnecting consumers by groupId Use broker API to disconnect only specific consumers on topics by groupId, so that unloading one plugin would not impact the functionality of other plugins consuming messages on the same topics. Bug: Issue 327226782 Change-Id: If87b7761598844dc0dac6289745bc54c1b7a35b9
diff --git a/src/main/java/com/googlesource/gerrit/plugins/replication/pull/event/EventsBrokerMessageConsumer.java b/src/main/java/com/googlesource/gerrit/plugins/replication/pull/event/EventsBrokerMessageConsumer.java index 795ce26..044409a 100644 --- a/src/main/java/com/googlesource/gerrit/plugins/replication/pull/event/EventsBrokerMessageConsumer.java +++ b/src/main/java/com/googlesource/gerrit/plugins/replication/pull/event/EventsBrokerMessageConsumer.java
@@ -81,6 +81,6 @@ @Override public void stop() { shutdownState.setIsShuttingDown(true); - eventsBrokerDi.get().disconnect(); + eventsBrokerDi.get().disconnect(eventsTopicName, groupId); } }
diff --git a/src/test/java/com/googlesource/gerrit/plugins/replication/pull/event/EventsBrokerMessageConsumerTest.java b/src/test/java/com/googlesource/gerrit/plugins/replication/pull/event/EventsBrokerMessageConsumerTest.java index 0aba20a..9e57d9f 100644 --- a/src/test/java/com/googlesource/gerrit/plugins/replication/pull/event/EventsBrokerMessageConsumerTest.java +++ b/src/test/java/com/googlesource/gerrit/plugins/replication/pull/event/EventsBrokerMessageConsumerTest.java
@@ -77,6 +77,6 @@ shutdownState.setIsShuttingDown(true); objectUnderTest.accept(new RefUpdatedEvent()); - verify(eventsBroker, times(1)).disconnect(); + verify(eventsBroker, times(1)).disconnect("topicName", null); } }