commit | 47a9e541bb4090fb1d5884b2ada3cda8694a61a6 | [log] [tgz] |
---|---|---|
author | Luca Milanesio <luca.milanesio@gmail.com> | Mon Mar 27 11:31:13 2017 +0100 |
committer | Luca Milanesio <luca.milanesio@gmail.com> | Mon Mar 27 11:33:26 2017 +0100 |
tree | 6ca9791b875ecfe3be1024f7604f58836259e865 | |
parent | 7499db2115f3f15975068cef5f648902647bb2f8 [diff] |
Filter out partial name matches in OWNERS file Make sure that the result of the account ids resolved from the OWNERS file lookup does not include any partial matches. Change-Id: Ic0dfe6f269ea4a60bb82efb3145495b730bfc327
This plugin provides some Prolog predicates that can be used to add customized validation checks based on the approval of ‘path owners’ of a particular folder in the project.
That allows creating a single big project including multiple components and users have different roles depending on the particular path where changes are being proposed. A user can be “owner” in a specific directory, and thus influencing the approvals of changes there, but cannot do the same in others paths, so assuring a kind of dynamic subproject access rights.
There are currently two main prolog public verbs:
add_owner_approval/3
(UserList, InList, OutList) appends label('Owner-Approval', need(_))
to InList building OutList if UserList has no users contained in the defined owners of this path change.
In other words, the predicate just copies InList to OutList if at least one of the elements in UserList is an owner.
add_owner_approval/2
(InList, OutList) appends label('Owner-Approval', need(_))
to InList building OutList if no owners has given a Code-Review +2 to this path change.
This predicate is similar to the first one but generates a UserList with an hardcoded policy.
Since add_owner_approval/3 is not using hard coded policies, it can be suitable for complex customizations.
There is a second plugin, gerrit-owners-autoassign which depends on gerrit-owners. It will automatically assign all of the owners to review a change when it's created or updated.
Create three symbolic links of the owners-owners, owners-common and owners-autoassign from the Gerrit source code /plugins directory to the subdirectories of this project.
Then build the owners and owners-autoassign plugins with the usual Gerrit plugin compile command.
NOTE: This plugin requires Java 8, even if Gerrit 2.13 can be built with Java 7. To enable Java 8 when building this plugin, append the .buckconfig to the Gerrit's one.
Example:
$ git clone https://gerrit.googlesource.com/plugins/owners $ git clone https://gerrit.googlesource.com/gerrit $ cd gerrit/plugins $ ln -s ../../owners/owners* . $ cd .. $ cat ../owners/.buckconfig >> .buckconfig $ buck test plugins/owners-common:test $ buck build plugins/owners plugins/owners-autoassign
NOTE: the owners-common folder is producing shared artifacts for the two plugins and does not need to be built separately being a direct dependency of the build process. Its resulting .jar must not be installed in gerrit plugins directory.