commit | 518840c5b86419c19e4fa2616e273a25998fad9b | [log] [tgz] |
---|---|---|
author | Ben Rohlfs <brohlfs@google.com> | Fri Apr 26 11:28:12 2024 +0200 |
committer | Prakash Aswal <prakash.aswal@linaro.org> | Fri May 10 06:35:15 2024 +0000 |
tree | d2c31a8233563b67f48392d231f597eccdbd973e | |
parent | 3ace3eb07a3438a95b1ea15dc66520f1ea47515c [diff] |
Fix vertical alignment of header icon and text There is generally a slight misalignment of icon and text as can be seen in this screenshot: https://imgur.com/a/tDUHGk0 It was also noted in the referenced bug that increasing the icon height is impossible, because then the alignment gets totally messed up. 3 problems contribute to this misalignment: 1. `.titleText` element being a span. This generally makes alignment of icons next to text very tricky. Let's use a flex element instead. 2. `vertical-align: text-bottom` for the icon is a very unusual choice for the vertical-align property and does not really make a lot of sense. Let's just use the `align-items: center` style for flex elements, see above. 3. `.bigTitle` has a custom font size, but not a custom line-height. That is generally problematic as can be seen here: The element will get a height of 20px as an inline element, but contains text with a 24.5px font. No surprise that we see misalignment. Let's make sure that the line-height and thus the height of the text element has a proper value. 1.2*font-size is what browsers would normally use. This was checked to behave well on gerrit-review, android-review and chromium-review. Release-Notes: skip Bug: Issue 337076005 Change-Id: Ia09bbe92158f7b4b1d6b88e599e0635fa9b15d5e (cherry picked from commit 06cfcb6ef54d78d7e68dfc0f17a15d30d6aae414)
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update && apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.